Skip to content

Conversation

@SergioGasquez
Copy link
Member

Basically this:

  • Deletes the old part 3
  • Old part 4 (mqtt with env variables) becomes part 3
  • Old part 5 (mqtt with provisioning) becomes part 4
  • Old part 6 (mqtt with provisioning and OTA) becomes part 5

@bjoernQ
Copy link
Contributor

bjoernQ commented Jan 27, 2026

removing part 3 makes a lot of sense to me

for similar reasoning I wonder if "part 2" makes a lot of sense (didactically wise) - I see we want to teach users how to connect to WiFi and to make it more interesting we also show how to send sensor data via http - but in the part we throw that away and replace it with MQTT and we show using HTTP again in part 🤷‍♂️

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I didn't try to really review this but since it's just shuffling around the parts, LGTM

@SergioGasquez
Copy link
Member Author

SergioGasquez commented Jan 28, 2026

for similar reasoning I wonder if "part 2" makes a lot of sense (didactically wise) - I see we want to teach users how to connect to WiFi and to make it more interesting we also show how to send sensor data via http - but in the part we throw that away and replace it with MQTT and we show using HTTP again in part 🤷‍♂️

I think if we remove part2 and include its content in part3, part3 will become hard to digest, imho having the two parts its better, although we could improve the http story.

cc: @MabezDev @jessebraham

@bjoernQ
Copy link
Contributor

bjoernQ commented Jan 28, 2026

we could improve the http story

At least we'd need a real endpoint that is doing something useful with that data - then in the next part we could explain why http is not ideal for this kind of data (overhead yadda yadda) and why MQTT is a better fit for this (and also sneak peek where it might be useful later) ... then I'd agree to keep it

UPD: but I guess we will see how things work out once we have the content describing it

@MabezDev
Copy link
Member

we could improve the http story

At least we'd need a real endpoint that is doing something useful with that data - then in the next part we could explain why http is not ideal for this kind of data (overhead yadda yadda) and why MQTT is a better fit for this (and also sneak peek where it might be useful later) ... then I'd agree to keep it

UPD: but I guess we will see how things work out once we have the content describing it

I think we can easily do something interesting with the data when we solve #87. We can at least print the received data.

Imo let's keep the structure as is, I think it flows quite well. We can supplement "boring" parts without too much change on either the code or writing side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants